fix(mesh): use memmove for overlapping path shift#1904
Open
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Open
fix(mesh): use memmove for overlapping path shift#1904robekl wants to merge 1 commit intomeshcore-dev:devfrom
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes undefined behavior in direct-route path rewriting by replacing an overlapping
memcpywithmemmove.Problem / Impact
removeSelfFromPath()shifts path entries left in-place after decrementing the hop count.Source and destination ranges overlap by design (
dest = path + k,src = path + k + sz).Using
memcpyon overlapping ranges is undefined behavior in C/C++.On embedded builds, UB here can lead to:
Because this function is in the packet forwarding path, even rare corruption can have high network reliability impact.
Why This Fix Is Correct
memmoveis defined for overlapping memory regions and preserves the intended in-place shift semantics.